[Openmp-commits] [PATCH] D137827: [openmp] Use z_Linux_asm.S to provide __kmp_invoke_microtask with Clang for Windows/aarch64

[Martin Storsjö via Phabricator via Openmp-commits]

mstorsjo added a comment.

In D137827#3949038 <https://reviews.llvm.org/D137827#3949038>, @DavidSpickett wrote:

> I have zero idea about OpenMP, just one comment on the cmake.

Yeah, it seems hard to get someone to approve this... I presume the asm changes look straightforward/ok to you too? I'm wrapping the `.comm` directive since the alignment in that directive is interpreted differently between ELF and COFF.



================
Comment at: openmp/runtime/src/CMakeLists.txt:101
+      libomp_append(LIBOMP_GNUASMFILES z_Linux_asm.S)
     endif()
   else()
----------------
DavidSpickett wrote:
> The implicit else here is `else use the .cpp file` ? This would happen when you are on AArch64 and using MSVC.
> 
> Worth adding that as a comment?
Sure, it never hurts to be more explicit with things like this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137827/new/

https://reviews.llvm.org/D137827