[Openmp-commits] [PATCH] D137827: [openmp] Use z_Linux_asm.S to provide __kmp_invoke_microtask with Clang for Windows/aarch64

[David Spickett via Phabricator via Openmp-commits]

DavidSpickett added a comment.

I have zero idea about OpenMP, just one comment on the cmake.



================
Comment at: openmp/runtime/src/CMakeLists.txt:101
+      libomp_append(LIBOMP_GNUASMFILES z_Linux_asm.S)
     endif()
   else()
----------------
The implicit else here is `else use the .cpp file` ? This would happen when you are on AArch64 and using MSVC.

Worth adding that as a comment?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137827/new/

https://reviews.llvm.org/D137827