[Openmp-commits] [PATCH] D138002: [OpenMP][libomptarget] Build plugins-nextgen/common/PluginInterface with protected visibility

[Kevin Sala Penadés via Phabricator via Openmp-commits]

kevinsala updated this revision to Diff 475653.
kevinsala added a comment.

Updated to use `set_target_properties` instead of `set_property`.

@jhuber6 I'd appreciate if you could commit the patch for me. Thank you in advance.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138002/new/

https://reviews.llvm.org/D138002

Files:
  openmp/libomptarget/plugins-nextgen/common/PluginInterface/CMakeLists.txt


Index: openmp/libomptarget/plugins-nextgen/common/PluginInterface/CMakeLists.txt
===================================================================
--- openmp/libomptarget/plugins-nextgen/common/PluginInterface/CMakeLists.txt
+++ openmp/libomptarget/plugins-nextgen/common/PluginInterface/CMakeLists.txt
@@ -19,7 +19,10 @@
 # Define the DEBUG_PREFIX.
 add_definitions(-DDEBUG_PREFIX="PluginInterface")
 
-set_property(TARGET PluginInterface PROPERTY POSITION_INDEPENDENT_CODE ON)
+set_target_properties(PluginInterface PROPERTIES
+  POSITION_INDEPENDENT_CODE ON
+  CXX_VISIBILITY_PRESET protected)
+
 llvm_update_compile_flags(PluginInterface)
 set(LINK_LLVM_LIBS LLVMSupport)
 if (LLVM_LINK_LLVM_DYLIB)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138002.475653.patch
Type: text/x-patch
Size: 705 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20221116/66d76aec/attachment.bin>