[Openmp-commits] [PATCH] D138002: [OpenMP][libomptarget] Build plugins-nextgen/common/PluginInterface with protected visibility

[Kevin Sala Penadés via Phabricator via Openmp-commits]

kevinsala added a comment.

In D138002#3926600 <https://reviews.llvm.org/D138002#3926600>, @jhuber6 wrote:

> In D138002#3926598 <https://reviews.llvm.org/D138002#3926598>, @jhuber6 wrote:
>
>> In D138002#3926596 <https://reviews.llvm.org/D138002#3926596>, @kevinsala wrote:
>>
>>> @jhuber6 Shouldn't we compile the `elf_common` "library" with protected visibility too?
>>
>> It should be fine since everything links from a single library. The previous problem was because we had multiple libraries defining the same functions in the plugins.
>
> Double checked, it should be an object library so it doesn't export anything on the library level, then the version script will ensure that we only export the plugin interfaces.

Thank you for checking it!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138002/new/

https://reviews.llvm.org/D138002