[Openmp-commits] [PATCH] D125698: [Libomptarget] Don't build the device runtime without a new Clang

[Joseph Huber via Phabricator via Openmp-commits]

jhuber6 added a comment.

In D125698#3516187 <https://reviews.llvm.org/D125698#3516187>, @ye-luo wrote:

>   This is either done with a two-step build, where OpenMP is built with
>   the Clang that was just installed, or through the
>   -DLLLVM_ENABLE_RUNTIMES=openmp option. This has always been the case,
>
> This is not true. Even before D125315 <https://reviews.llvm.org/D125315> breakage, all the host libraries can be built with GCC and DeviceRTL with just-built Clang via `-DLLVM_ENABLE_PROJECTS=openmp` 
> Maybe we should figure out why D125315 <https://reviews.llvm.org/D125315> doesn't pick up clang when building DeviceRTL.

The old method called the binaries directly, the expected configurations to get this is `-DLLVM_ENABLE_RUNTIMES=openmp` or `-DLLVM_ENABLE_PROJECTS=openmp` with a newly built Clang. I'm not sure if there's a way we can try to build this with another compiler now. D125315 <https://reviews.llvm.org/D125315> was a somewhat breaking change, I could just guard it manually there so you can still get the old libraries build with the clang binaries you have somewhere, but realistically it's not a supported build configuration.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125698/new/

https://reviews.llvm.org/D125698