[Openmp-commits] [PATCH] D124812: [OpenMP] Possible fix for sporadic test failure from loop_dispatch.c

Hansang Bae via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue May 3 12:47:25 PDT 2022


This revision was automatically updated to reflect the committed changes.
Closed by commit rG7e23b46ab8da: [OpenMP] Possible fix for sporadic test failure from loop_dispatch.c (authored by hbae).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124812/new/

https://reviews.llvm.org/D124812

Files:
  openmp/runtime/test/ompt/worksharing/for/loop_dispatch.c


Index: openmp/runtime/test/ompt/worksharing/for/loop_dispatch.c
===================================================================
--- openmp/runtime/test/ompt/worksharing/for/loop_dispatch.c
+++ openmp/runtime/test/ompt/worksharing/for/loop_dispatch.c
@@ -9,22 +9,33 @@
 
 int main() {
   int i;
+  int wait_s = 0;
 
 #pragma omp parallel num_threads(4)
   {
+    int wait_id = 0;
+    int team_size = omp_get_num_threads();
 #pragma omp for schedule(static, WORK_SIZE / 4)
     for (i = 0; i < WORK_SIZE; i++) {}
 
 #pragma omp for schedule(dynamic)
     for (i = 0; i < WORK_SIZE; i++) {
-      // Make every iteration takes at least 1ms.
-      delay(1000);
+      if (wait_id == 0) {
+        // Wait until every thread has at least one iteration assigned
+        OMPT_SIGNAL(wait_s);
+        OMPT_WAIT(wait_s, team_size);
+        wait_id++;
+      }
     }
 
 #pragma omp for schedule(guided)
     for (i = 0; i < WORK_SIZE; i++) {
-      // Make every iteration takes at least 1ms.
-      delay(1000);
+      if (wait_id == 1) {
+        // Wait until every thread has at least one iteration assigned
+        OMPT_SIGNAL(wait_s);
+        OMPT_WAIT(wait_s, 2 * team_size);
+        wait_id++;
+      }
     }
   }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D124812.426808.patch
Type: text/x-patch
Size: 1228 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20220503/290172be/attachment.bin>


More information about the Openmp-commits mailing list