[Openmp-commits] [PATCH] D124812: [OpenMP] Possible fix for sporadic test failure from loop_dispatch.c

[Joachim Protze via Phabricator via Openmp-commits]

protze.joachim added a comment.

Thanks for the fix! I'm quite confident that this change will fix the sporiadic test failures (most probably under high system load).

I suggest to refer D122107 <https://reviews.llvm.org/D122107> in the commit message. 
And I also suggest to use the actual team size in the `OMPT_WAIT`, just to prevent deadlock in case less threads are provided.



================
Comment at: openmp/runtime/test/ompt/worksharing/for/loop_dispatch.c:25
+        OMPT_SIGNAL(wait_s);
+        OMPT_WAIT(wait_s, 4);
+        wait_id++;
----------------



================
Comment at: openmp/runtime/test/ompt/worksharing/for/loop_dispatch.c:35
+        OMPT_SIGNAL(wait_s);
+        OMPT_WAIT(wait_s, 8);
+        wait_id++;
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124812/new/

https://reviews.llvm.org/D124812