[Openmp-commits] [PATCH] D122667: llvm14 patch: hwloc include directory for libompd

Wed Mar 30 13:17:22 PDT 2022

tianshilei1992 added a comment.

In D122667#3417554 <https://reviews.llvm.org/D122667#3417554>, @Ericson2314 wrote:

> @tianshilei1992 Oh sorry you were talking about https://cmake.org/cmake/help/latest/prop_tgt/INTERFACE_INCLUDE_DIRECTORIES.html#prop_tgt:INTERFACE_INCLUDE_DIRECTORIES that behavior right? Specific to when `target_link_library` is used to depend on a target and not, say, an external preexisting library file.
>
> So the
>
>   add_dependencies(ompd omp)
>
> need to be replaced with a `target_link_libraries(ompd omp)`, right?

Right. As long as `omp` is set properly, `target_link_libraries` can set everything else automatically.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122667/new/

https://reviews.llvm.org/D122667