[Openmp-commits] [PATCH] D122667: llvm14 patch: hwloc include directory for libompd

Wed Mar 30 12:24:10 PDT 2022

tianshilei1992 added a comment.

In D122667#3417470 <https://reviews.llvm.org/D122667#3417470>, @Ericson2314 wrote:

> Hmm. Do you have docs for this, I would like for you to be right? https://cmake.org/cmake/help/latest/command/target_link_libraries.html only mentions macOS framework includes.

https://cmake.org/cmake/help/latest/command/target_include_directories.html

> The INTERFACE, PUBLIC and PRIVATE keywords are required to specify the scope of the following arguments. PRIVATE and PUBLIC items will populate the INCLUDE_DIRECTORIES property of <target>. PUBLIC and INTERFACE items will populate the INTERFACE_INCLUDE_DIRECTORIES property of <target>. The following arguments specify include directories.

https://cmake.org/cmake/help/latest/prop_tgt/INTERFACE_INCLUDE_DIRECTORIES.html#prop_tgt:INTERFACE_INCLUDE_DIRECTORIES

This feature is actively used in `libomptarget`. For example, in `openmp/libomptarget/plugins/cuda/CMakeLists.txt` the target `omptarget.rtl.cuda` depends on `elf_common`, which is defined in `openmp/libomptarget/plugins/common/elf_common/CMakeLists.txt`, but we don't set include directory for `omptarget.rtl.cuda` to include headers of `elf_common`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122667/new/

https://reviews.llvm.org/D122667