[Openmp-commits] [PATCH] D122667: llvm14 patch: hwloc include directory for libompd

Shilei Tian via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Mar 30 11:57:22 PDT 2022


tianshilei1992 added a comment.

In D122667#3417369 <https://reviews.llvm.org/D122667#3417369>, @Ericson2314 wrote:

> I don't think `target_link_libraries` effects headers at all, so while it is good it is a big of a red herring.

No, it does. If the CMake target is created properly, it will have `target_include_directories` with `INTERFACE`, and then the include directories will be propagated if someone else links the library.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122667/new/

https://reviews.llvm.org/D122667



More information about the Openmp-commits mailing list