[Openmp-commits] [PATCH] D122667: llvm14 patch: hwloc include directory for libompd

John Ericson via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Mar 30 11:28:19 PDT 2022


Ericson2314 added a comment.

We can land this simple one now, but I really don't like doing stop-gap fixes on development branches instead of fixing the underlying issue. The fact of the matter is, if tech debt isn't fixed as prompted by bugs, it usually never gets fixed at all.

I don't think `target_link_libraries` effects headers at all, so while it is good it is a big of a red herring.

The instructions I gave above with `add_custom_target(libomp-kmp-headers)` should work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122667/new/

https://reviews.llvm.org/D122667



More information about the Openmp-commits mailing list