[Openmp-commits] [PATCH] D122667: llvm14 patch: hwloc include directory for libompd

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added inline comments.


================
Comment at: openmp/runtime/src/CMakeLists.txt:50
 if(${LIBOMP_USE_HWLOC})
-  include_directories(${LIBOMP_HWLOC_INSTALL_DIR}/include)
+  target_include_directories(${LIBOMP_HWLOC_INSTALL_DIR}/include PUBLIC)
 endif()
----------------
tianshilei1992 wrote:
> https://cmake.org/cmake/help/latest/command/target_include_directories.html
> The target name is missing.
Not sure if `PUBLIC` is the right one here. If something else depends on `omp`, does the header need to be propagated?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122667/new/

https://reviews.llvm.org/D122667