[Openmp-commits] [PATCH] D122667: llvm14 patch: hwloc include directory for libompd

[John Ericson via Phabricator via Openmp-commits]

Ericson2314 added a comment.

@tianshilei is right. Basically the older CMake stuff like `include_directories` only worked by side effects, and therefore is impossible to use correctly and modulary and is just generally terrible. the new `target` stuff is much better, and actually allows tracking who depends on what.

`target_link_libraries` is definitely a good idea, but I not trying to force @s-sajid-ali to fix the world just to fix the bug :). If we can just get away with `target_include_directories` that is a good initial step.

@andreychurbanov Can you explain

> No, it is used for library internals only. And libompd wants to include libomp's internal header, so I am not sure how target_include_directories can apply here.

in a bit more detail? I know CMake quote well, but not the LLVM openmp stuff.

Is `kmp.h` that includes `hwloc.h` installed or not? If it is installed, then what @s-sajid-ali is correct even if the header is not really designed for external use. If it is not installed, then we will have to be more careful about what "target" to use.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122667/new/

https://reviews.llvm.org/D122667