[Openmp-commits] [PATCH] D122667: llvm14 patch: hwloc include directory for libompd

Wed Mar 30 09:38:08 PDT 2022

tianshilei1992 requested changes to this revision.
tianshilei1992 added a comment.
This revision now requires changes to proceed.

The best way to handle include and link is via `target_link_libraries` (https://cmake.org/cmake/help/latest/command/target_link_libraries.html). This requires to search/find `hwloc` library in a CMake standard way, and link it properly. Everything else will be handled correctly.

================
Comment at: openmp/runtime/src/CMakeLists.txt:50
 if(${LIBOMP_USE_HWLOC})
-  include_directories(${LIBOMP_HWLOC_INSTALL_DIR}/include)
+  target_include_directories(${LIBOMP_HWLOC_INSTALL_DIR}/include PUBLIC)
 endif()
----------------
https://cmake.org/cmake/help/latest/command/target_include_directories.html
The target name is missing.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122667/new/

https://reviews.llvm.org/D122667