[Openmp-commits] [PATCH] D122667: llvm14 patch: hwloc include directory for libompd

[Andrey Churbanov via Phabricator via Openmp-commits]

AndreyChurbanov added a comment.

In D122667#3416686 <https://reviews.llvm.org/D122667#3416686>, @Ericson2314 wrote:

> In openmp/runtime/src/CMakeLists.txt in particular we have
>
>   if(${LIBOMP_USE_HWLOC})
>      include_directories(${LIBOMP_HWLOC_INSTALL_DIR}/include)
>   endif()
>
> The problem is that `include_directories` just affects the current build, but `hwloc.h` is being included in a *public* header, right?

No, it is used for library internals only. And libompd wants to include libomp's internal header, so I am not sure how `target_include_directories` can apply here.

Current patch does not work.  I think the solution would be to add same conditional include_directories to `openmp/libompd/src/CMakeLists.txt`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122667/new/

https://reviews.llvm.org/D122667