[Openmp-commits] [PATCH] D122667: llvm14 patch: hwloc include directory for libompd

[John Ericson via Phabricator via Openmp-commits]

Ericson2314 added a comment.

`LIBOMP_INCLUDE_DIR` is a weird name because aren't we building `libomp`? That should be a directory were headers are build/installed not where they are gotten from. For hermetic builds, the distinction of locations to read vs locations to write is very important.

I would prefer a morecomprehensive fix that starts with auditing

  $ git grep LIBOMP_INCLUDE_DIR
  openmp/libompd/src/CMakeLists.txt:        ${LIBOMP_INCLUDE_DIR}
  openmp/libomptarget/CMakeLists.txt:set(LIBOMPTARGET_OPENMP_HEADER_FOLDER "${LIBOMP_INCLUDE_DIR}" CACHE STRING
  openmp/runtime/CMakeLists.txt:set(LIBOMP_INCLUDE_DIR ${LIBOMP_INCLUDE_DIR} PARENT_SCOPE)
  openmp/runtime/src/CMakeLists.txt:set(LIBOMP_INCLUDE_DIR ${CMAKE_CURRENT_BINARY_DIR} PARENT_SCOPE)
  openmp/runtime/src/CMakeLists.txt:set(LIBOMP_INCLUDE_DIR ${CMAKE_CURRENT_BINARY_DIR} PARENT_SCOPE)
  openmp/tools/archer/CMakeLists.txt:  include_directories(${LIBOMP_INCLUDE_DIR})
  openmp/tools/archer/tests/lit.site.cfg.in:config.omp_header_dir = "@LIBOMP_INCLUDE_DIR@"
  openmp/tools/multiplex/CMakeLists.txt:  include_directories(${LIBOMP_INCLUDE_DIR})
  openmp/tools/multiplex/tests/lit.site.cfg.in:config.omp_header_dir = "@LIBOMP_INCLUDE_DIR@"

to get a better idea of how this variable is currently used and what it is a *for*.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122667/new/

https://reviews.llvm.org/D122667