[Openmp-commits] [PATCH] D121467: [Libomptarget] Create device math wrappers

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

Sounds good to me.

In D121467#3375618 <https://reviews.llvm.org/D121467#3375618>, @jdoerfert wrote:

> Changing to macros is something we can do and might even allow us to cut down the files by one.
> With something like MAP(from, to, return_type, arg_types) we might be able to create the wrappers from sin -> __llvm_gpu_sin, and from __llvm_gpu_sin -> sin, and from sin -> __{nv,ocml}_sin.
>
> All that said, the macros could have been done before, and can be done after this rewrite.

I'm going to look at that now - have got a few use cases for essentially the same macro. It'll be `MAP(from, to, arity)` though, writing out the types by hand is tedious and avoidable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121467/new/

https://reviews.llvm.org/D121467