[Openmp-commits] [PATCH] D121059: [OpenMP][FIX] Ensure flag to disable de-globalization works properly

Johannes Doerfert via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Sat Mar 5 13:52:06 PST 2022


jdoerfert created this revision.
jdoerfert added a reviewer: jhuber6.
Herald added subscribers: ormris, guansong, bollu, hiraditya, yaxunl.
Herald added a project: All.
jdoerfert requested review of this revision.
Herald added subscribers: llvm-commits, sstefan1.
Herald added a project: LLVM.

If the user disables de-globalization we did not seed the AAHeapToShared
and AAHeapToStack but we still could end up with them through in-flight
lookups. With this patch we disable AAHeapToShared completely if the
user disabled de-globalization. Heap-2-stack is still run though.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D121059

Files:
  llvm/lib/Transforms/IPO/OpenMPOpt.cpp


Index: llvm/lib/Transforms/IPO/OpenMPOpt.cpp
===================================================================
--- llvm/lib/Transforms/IPO/OpenMPOpt.cpp
+++ llvm/lib/Transforms/IPO/OpenMPOpt.cpp
@@ -2963,6 +2963,11 @@
   }
 
   void initialize(Attributor &A) override {
+    if (DisableOpenMPOptDeglobalization) {
+      indicatePessimisticFixpoint();
+      return;
+    }
+
     auto &OMPInfoCache = static_cast<OMPInformationCache &>(A.getInfoCache());
     auto &RFI = OMPInfoCache.RFIs[OMPRTL___kmpc_alloc_shared];
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D121059.413250.patch
Type: text/x-patch
Size: 524 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20220305/b5ca4c9a/attachment.bin>


More information about the Openmp-commits mailing list