[Openmp-commits] [PATCH] D130030: [OpenMP][DeviceRTL] Use `__atomic_exchange_n` to implement atomicStore

Shilei Tian via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon Jul 18 11:45:29 PDT 2022


tianshilei1992 planned changes to this revision.
tianshilei1992 added a comment.

In D130030#3660553 <https://reviews.llvm.org/D130030#3660553>, @jdoerfert wrote:

> LG, though the backend should be able to handle this, IMHO

Yeah, `__atomic_exchange_n` is expanded based on the ordering, and one of the expansion is still atomic store, which goes back to current situation. `atomic::store` is only being used by AMDGPU to implement named barrier. I'm wondering if we want to drop `atomic::store` and use the `__atomic_store_n` wherever it needs?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130030/new/

https://reviews.llvm.org/D130030



More information about the Openmp-commits mailing list