[Openmp-commits] [PATCH] D117526: [Libomptarget] Fix external visibility for internal variables

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added inline comments.


================
Comment at: openmp/libomptarget/DeviceRTL/include/Types.h:195
 //       now that's not the case.
 #define THREAD_LOCAL(NAME)                                                     \
+  NAME [[clang::loader_uninitialized, clang::address_space(5),                 \
----------------
Why would we want a visibility tag on stack variables? They shouldn't be in the elf at all


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117526/new/

https://reviews.llvm.org/D117526