[Openmp-commits] [PATCH] D117526: [Libomptarget] Fix external visibility for internal variables

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

In D117526#3251741 <https://reviews.llvm.org/D117526#3251741>, @jhuber6 wrote:

> In D117526#3251720 <https://reviews.llvm.org/D117526#3251720>, @ronlieb wrote:
>
>> Hi Joseph,
>> 3 commits came in, one bot exited with a fail
>> https://lab.llvm.org/buildbot/#/builders/193/builds/4828
>
> Is it possible that AMDGPU doesn't support static on these variables? I tested https://reviews.llvm.org/D117362 on my AMDGPU machine and didn't notice any problems, but didn't test with this one applies. I can test locally but it'll take awhile to rebuild on AMDGPU.

Previously, static shared variables did not work. Seems plausible that static thread local variables won't work either. Address space 5 roughly means __private, i.e. on the stack alloca style. I haven't worked through what this variable is used for yet.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117526/new/

https://reviews.llvm.org/D117526