[Openmp-commits] [PATCH] D117513: [Libomptarget] Add `cold` to KeepAlive attributes
Shilei Tian via Phabricator via Openmp-commits
openmp-commits at lists.llvm.org
Mon Jan 17 14:27:07 PST 2022
tianshilei1992 added a comment.
In D117513#3249539 <https://reviews.llvm.org/D117513#3249539>, @jhuber6 wrote:
> In D117513#3249536 <https://reviews.llvm.org/D117513#3249536>, @tianshilei1992 wrote:
>> LG. Do we want a test that checks if the remark is not emitted?
> I did a test locally and it resolved the issue, but it's not necessary because I already have a test that doesn't emit a remark if the cold attribute is present in OpenMPOpt's tests.
We don't have check line(s) in the test case?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the Openmp-commits