[Openmp-commits] [PATCH] D117513: [Libomptarget] Add `cold` to KeepAlive attributes

Joseph Huber via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon Jan 17 14:14:30 PST 2022


jhuber6 added a comment.

In D117513#3249536 <https://reviews.llvm.org/D117513#3249536>, @tianshilei1992 wrote:

> LG. Do we want a test that checks if the remark is not emitted?

I did a test locally and it resolved the issue, but it's not necessary because I already have a test that doesn't emit a remark if the cold attribute is present in OpenMPOpt's tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117513/new/

https://reviews.llvm.org/D117513



More information about the Openmp-commits mailing list