[Openmp-commits] [PATCH] D119988: [OpenMP][Offloading] Fix test case issues in bug49334.cpp

Wed Feb 23 11:59:23 PST 2022

tianshilei1992 marked an inline comment as done.
tianshilei1992 added inline comments.

================
Comment at: openmp/libomptarget/test/offloading/bug49334.cpp:76
 constexpr const int BS = 16;
-constexpr const int N = 256;
+constexpr const int N = 16;

----------------
hyviquel wrote:
> @tianshilei1992 By changing N to 16, it uses only a single block thus becomes a simple matrix multiplication and the test lost the interest of having multiple concurent target tasks...
Yes, but it can also make problems easier to be reproduced, like the one hidden in the test case itself. In addition, since the target region has `nowait`, one task or multiple tasks make no difference for the `taskwait`, which can meet our expectation for the test.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119988/new/

https://reviews.llvm.org/D119988