[Openmp-commits] [PATCH] D120142: [OpenMP][CUDA] Use one event pool per device

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added inline comments.


================
Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:176
+protected:
   CUcontext Context;
+};
----------------
tianshilei1992 wrote:
> I don't think it's good to put `CUcontext` in allocator. That template is only a reference for other specialization.
It was but it is not anymore. It is a base class now. Can you elaborate why you think it's not good to put a CUcontext in here? After all, all the associated allocators do allocate things that are bound to a/this context.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120142/new/

https://reviews.llvm.org/D120142