[Openmp-commits] [PATCH] D119747: [Libomptarget][NFC] Remove constexpr to hide warnings

Mon Feb 14 15:08:56 PST 2022

jhuber6 added a comment.

In D119747#3320903 <https://reviews.llvm.org/D119747#3320903>, @JonChesterfield wrote:

> Nvm, saw the commit message
>
> This is a variant thing iiuc. Can we fix the warning without losing the O0 compile time constant by defining a non-variant version of this function?

Says so in the commit message `Mapping.cpp:32:32: warning: inline function '_OMP::impl::getGridValue' is not defined [-Wundefined-inline]`. I'm not sure why it happened here. Might be some weird interaction with variant or something, I just wanted to stop getting these warnings every time I built the runtime and this was the easiest way.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119747/new/

https://reviews.llvm.org/D119747