[Openmp-commits] [PATCH] D118988: [OpenMP] kmp_atomic_float10_max_min.c test should only be executed on x86 platform

[Kelvin Li via Phabricator via Openmp-commits]

kkwli0 added a comment.

@igor.kirillov Adding `// UNSUPPORTED: aarch64` may not work because the `config.target_triplet` is empty. Actually, it currently does not work on Power with `// UNSUPPORTED: powerpc`.  And I experiment the following changes but I am not sure about the overall impact.

  diff --git a/openmp/runtime/test/lit.cfg b/openmp/runtime/test/lit.cfg
  index c1d240eaa80a..4dca14c35c38 100644
  --- a/openmp/runtime/test/lit.cfg
  +++ b/openmp/runtime/test/lit.cfg
  @@ -56,7 +56,7 @@ if config.has_libatomic:
       libs += " -latomic"
   
   # Allow REQUIRES / UNSUPPORTED / XFAIL to work
  -config.target_triple = [ ]
   for feature in config.test_compiler_features:
       config.available_features.add(feature)
   
  diff --git a/openmp/runtime/test/lit.site.cfg.in b/openmp/runtime/test/lit.site.cfg.in
  index dae5b9007931..2c6ca43d3e71 100644
  --- a/openmp/runtime/test/lit.site.cfg.in
  +++ b/openmp/runtime/test/lit.site.cfg.in
  @@ -1,5 +1,6 @@
   @AUTO_GEN_COMMENT@
   
  +config.target_triple = "@TARGET_TRIPLE@"
   config.test_c_compiler = "@OPENMP_TEST_C_COMPILER@"
   config.test_cxx_compiler = "@OPENMP_TEST_CXX_COMPILER@"
   config.test_compiler_features = @OPENMP_TEST_COMPILER_FEATURES@


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118988/new/

https://reviews.llvm.org/D118988