[Openmp-commits] [PATCH] D140591: [OpenMP] Solve potential VERSION script error w/ OMPT symbols

Jan-Patrick Lehr via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Dec 23 02:03:22 PST 2022


jplehr added a comment.

In D140591#4014320 <https://reviews.llvm.org/D140591#4014320>, @jhuber6 wrote:

> I don't think you can assign functions to zero, since these are functions we should probably just make them empty or return `nullptr` just in case someone actually calls it. Also these will need to be `extern "C"` since we're in a C++ file. Also, go ahead and put it at the bottom of the file since these have zero utility it shouldn't be the first thing the user sees.

Thank you Joseph. I'll fix that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140591/new/

https://reviews.llvm.org/D140591



More information about the Openmp-commits mailing list