[Openmp-commits] [PATCH] D140591: [OpenMP] Solve potential VERSION script error w/ OMPT symbols

Fri Dec 23 02:02:39 PST 2022

jplehr added a comment.

In D140591#4014743 <https://reviews.llvm.org/D140591#4014743>, @dhruvachak wrote:

> I don't know why the problem is showing up now. ompt_start_tool has been there for a long time. While libomp_ompt_connect is new, it is unconditionally defined.
>
> BTW, both of them are defined in openmp/runtime/src/ompt-general.cpp.

AFAICT the issue shows up when linkers error out when trying to export symbols that are not present. This is behavior that was changed in more recent versions of, e.g., lld.

While these are defined in the ompt-general.cpp file, this file is not included in the build when the user wants to build w/o OMPT support. The VERSION script, however, does not respect these configure-time options, so it tries to export the symbols, which are not there.
So, I thought, we should simply have these symbols defined somewhere, even w/o OMPT support., so the VERSION script does not complain.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140591/new/

https://reviews.llvm.org/D140591