[Openmp-commits] [PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a comment.

Could we elaborate on the benefits, please. Now we support two versions?

Why is this helpful:

> DeviceRTL uses rocm-device-libs instead of directly calling amdgcn builtins for the functions which are affected by cov5.



================
Comment at: openmp/libomptarget/DeviceRTL/src/State.cpp:81
+#endif
+} // extern "C"
+
----------------
Why do we need the "external..." stuff anyway?


================
Comment at: openmp/libomptarget/plugins/amdgpu/src/rtl.cpp:2233
+  }
+}
+
----------------
What is this all about?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139730/new/

https://reviews.llvm.org/D139730