[Openmp-commits] [EXTERNAL] [PATCH] D139139: Enable kmpc_atomic functions for arm64

[Bran Hagger via Openmp-commits]

It produces warnings when built with MSVC, but I think you're right that this is probably okay. The warnings can be suppressed in the command line arguments for the build. It looks like they already occur in a few other places, as we've already suppressed them in our build pipeline.

Thank you,
Bran
________________________________
From: Martin Storsjö via Phabricator <reviews at reviews.llvm.org>
Sent: Sunday, December 4, 2022 1:17 PM
To: Bran Hagger <brhagger at microsoft.com>; jdoerfert at anl.gov <jdoerfert at anl.gov>; martin at martin.st <martin at martin.st>
Cc: zhang.guansong at gmail.com <zhang.guansong at gmail.com>; xw111luoye at gmail.com <xw111luoye at gmail.com>; vigbalas at amd.com <vigbalas at amd.com>; sunil.shrestha at hpe.com <sunil.shrestha at hpe.com>; soutomar at amd.com <soutomar at amd.com>; sara.royuela at bsc.es <sara.royuela at bsc.es>; Saiyedul.Islam at amd.com <Saiyedul.Islam at amd.com>; ron.lieberman at amd.com <ron.lieberman at amd.com>; ravi.narayanaswamy at intel.com <ravi.narayanaswamy at intel.com>; misono.tomohiro at fujitsu.com <misono.tomohiro at fujitsu.com>; michael.hliao at gmail.com <michael.hliao at gmail.com>; lin32 at llnl.gov <lin32 at llnl.gov>; liao6 at llnl.gov <liao6 at llnl.gov>; kevin.sala at bsc.es <kevin.sala at bsc.es>; jinsong.ji at intel.com <jinsong.ji at intel.com>; jdenny.ornl at gmail.com <jdenny.ornl at gmail.com>; jatin.bhateja at gmail.com <jatin.bhateja at gmail.com>; greg63706 at gmail.com <greg63706 at gmail.com>; deepak.eachempati at hpe.com <deepak.eachempati at hpe.com>; david.green at arm.com <david.green at arm.com>; chichun.chen at hpe.com <chichun.chen at hpe.com>; bhuvanendra.kumarn at amd.com <bhuvanendra.kumarn at amd.com>; balaji-sankar-naga-sai-sandeep.kosuri at hpe.com <balaji-sankar-naga-sai-sandeep.kosuri at hpe.com>; abidmuslim at gmail.com <abidmuslim at gmail.com>; a.bataev at hotmail.com <a.bataev at hotmail.com>; nataliaglagoleva at gmail.com <nataliaglagoleva at gmail.com>; stefomeister at gmail.com <stefomeister at gmail.com>; openmp-commits at lists.llvm.org <openmp-commits at lists.llvm.org>; kristof.beyls at arm.com <kristof.beyls at arm.com>; phoebe.wang at intel.com <phoebe.wang at intel.com>
Subject: [EXTERNAL] [PATCH] D139139: Enable kmpc_atomic functions for arm64

mstorsjo added a comment.

Thanks, this version builds successfully for me - but I presume this configuration produces warnings when built with MSVC?

(Btw, when uploading diffs, keep in mind that Phabricator works best if you include extra context, e.g. `git diff -U999`.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD139139%2Fnew%2F&data=05%7C01%7Cbrhagger%40microsoft.com%7C29e2f282611047460f5f08dad63d0537%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638057854819129187%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=YvoxNvkLC7Tesf4EOci1%2BpmZDwJIlMvQLZv6MVHcv1s%3D&reserved=0

https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD139139&data=05%7C01%7Cbrhagger%40microsoft.com%7C29e2f282611047460f5f08dad63d0537%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638057854819129187%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=REOu6KAyktKdjez534SZHsxa%2BZykY60Vg992zKa19dM%3D&reserved=0

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20221205/4e7bf544/attachment-0001.html>