<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class="elementToProof">
It produces warnings when built with MSVC, but I think you're right that this is probably okay. The warnings can be suppressed in the command line arguments for the build. It looks like they already occur in a few other places, as we've already suppressed them
in our build pipeline.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class="elementToProof">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class="elementToProof">
Thank you,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class="elementToProof">
Bran</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Martin Storsjö via Phabricator <reviews@reviews.llvm.org><br>
<b>Sent:</b> Sunday, December 4, 2022 1:17 PM<br>
<b>To:</b> Bran Hagger <brhagger@microsoft.com>; jdoerfert@anl.gov <jdoerfert@anl.gov>; martin@martin.st <martin@martin.st><br>
<b>Cc:</b> zhang.guansong@gmail.com <zhang.guansong@gmail.com>; xw111luoye@gmail.com <xw111luoye@gmail.com>; vigbalas@amd.com <vigbalas@amd.com>; sunil.shrestha@hpe.com <sunil.shrestha@hpe.com>; soutomar@amd.com <soutomar@amd.com>; sara.royuela@bsc.es <sara.royuela@bsc.es>;
Saiyedul.Islam@amd.com <Saiyedul.Islam@amd.com>; ron.lieberman@amd.com <ron.lieberman@amd.com>; ravi.narayanaswamy@intel.com <ravi.narayanaswamy@intel.com>; misono.tomohiro@fujitsu.com <misono.tomohiro@fujitsu.com>; michael.hliao@gmail.com <michael.hliao@gmail.com>;
lin32@llnl.gov <lin32@llnl.gov>; liao6@llnl.gov <liao6@llnl.gov>; kevin.sala@bsc.es <kevin.sala@bsc.es>; jinsong.ji@intel.com <jinsong.ji@intel.com>; jdenny.ornl@gmail.com <jdenny.ornl@gmail.com>; jatin.bhateja@gmail.com <jatin.bhateja@gmail.com>; greg63706@gmail.com
<greg63706@gmail.com>; deepak.eachempati@hpe.com <deepak.eachempati@hpe.com>; david.green@arm.com <david.green@arm.com>; chichun.chen@hpe.com <chichun.chen@hpe.com>; bhuvanendra.kumarn@amd.com <bhuvanendra.kumarn@amd.com>; balaji-sankar-naga-sai-sandeep.kosuri@hpe.com
<balaji-sankar-naga-sai-sandeep.kosuri@hpe.com>; abidmuslim@gmail.com <abidmuslim@gmail.com>; a.bataev@hotmail.com <a.bataev@hotmail.com>; nataliaglagoleva@gmail.com <nataliaglagoleva@gmail.com>; stefomeister@gmail.com <stefomeister@gmail.com>; openmp-commits@lists.llvm.org
<openmp-commits@lists.llvm.org>; kristof.beyls@arm.com <kristof.beyls@arm.com>; phoebe.wang@intel.com <phoebe.wang@intel.com><br>
<b>Subject:</b> [EXTERNAL] [PATCH] D139139: Enable kmpc_atomic functions for arm64</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">mstorsjo added a comment.<br>
<br>
Thanks, this version builds successfully for me - but I presume this configuration produces warnings when built with MSVC?<br>
<br>
(Btw, when uploading diffs, keep in mind that Phabricator works best if you include extra context, e.g. `git diff -U999`.)<br>
<br>
<br>
Repository:<br>
rG LLVM Github Monorepo<br>
<br>
CHANGES SINCE LAST ACTION<br>
<a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD139139%2Fnew%2F&data=05%7C01%7Cbrhagger%40microsoft.com%7C29e2f282611047460f5f08dad63d0537%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638057854819129187%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=YvoxNvkLC7Tesf4EOci1%2BpmZDwJIlMvQLZv6MVHcv1s%3D&reserved=0">
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD139139%2Fnew%2F&data=05%7C01%7Cbrhagger%40microsoft.com%7C29e2f282611047460f5f08dad63d0537%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638057854819129187%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=YvoxNvkLC7Tesf4EOci1%2BpmZDwJIlMvQLZv6MVHcv1s%3D&reserved=0</a><br>
<br>
<a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD139139&data=05%7C01%7Cbrhagger%40microsoft.com%7C29e2f282611047460f5f08dad63d0537%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638057854819129187%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=REOu6KAyktKdjez534SZHsxa%2BZykY60Vg992zKa19dM%3D&reserved=0">https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD139139&data=05%7C01%7Cbrhagger%40microsoft.com%7C29e2f282611047460f5f08dad63d0537%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638057854819129187%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=REOu6KAyktKdjez534SZHsxa%2BZykY60Vg992zKa19dM%3D&reserved=0</a><br>
<br>
</div>
</span></font></div>
</body>
</html>