[Openmp-commits] [PATCH] D132925: Add LoongArch64 Support For OpenMP

Wed Aug 31 06:57:31 PDT 2022

prcups added a comment.

In D132925#3758209 <https://reviews.llvm.org/D132925#3758209>, @SixWeining wrote:

> Thanks.
>
> This touches files like D59880 <https://reviews.llvm.org/D59880> did except `openmp/runtime/src/thirdparty/ittnotify/ittnotify_config.h` and outdated `openmp/www`. For `ittnotify` I suppose we do not need to change it because D109333 <https://reviews.llvm.org/D109333>.
>
> Some concerns:
>
> 1. Have you tested existing testcases on a native LoongArch machine? If so, do you use `clang` or `gcc`?
> 2. Do we need to add new tests?

For 1, I tried to use "make check", unfortunately, almost all test unit failed. Threads crash just before ending and it seems to be about stack. The crash happened at the end of process __kmp_invoke_task_func near __kmp_run_after_invoked_task. I 'm trying to find the possible cause.
For 2, because RISC-V doesn't have particular test, and I think common tests on loongarch are adequate to find errors, it is not neccessary to add new tests.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132925/new/

https://reviews.llvm.org/D132925