[Openmp-commits] [openmp] 52556c3 - [Libomptarget] Make unified shared memory test unsupported on AMDGPU

Joseph Huber via Openmp-commits openmp-commits at lists.llvm.org
Tue Aug 30 10:14:39 PDT 2022


Author: Joseph Huber
Date: 2022-08-30T12:14:25-05:00
New Revision: 52556c3c0f942cdb644e8548d9956b24bd9bba59

URL: https://github.com/llvm/llvm-project/commit/52556c3c0f942cdb644e8548d9956b24bd9bba59
DIFF: https://github.com/llvm/llvm-project/commit/52556c3c0f942cdb644e8548d9956b24bd9bba59.diff

LOG: [Libomptarget] Make unified shared memory test unsupported on AMDGPU

This test is an expected failure on AMDGPU. The expected failure is a GPU memory
failure, which will typically result in the device totally failing. This isn't
an issue for some GPU configurations that do not use the offloading device to
also drive the display server. However, if the main GPU is used for testing it
will reliably result in the user's display becoming unresponsive. This makes it
difficult to run the GPU offloading tests on many systems.

This patch simply makes this test unsupported so it no longer runs and freezes
my computer when using `ninja check-openmp`.

Reviewed By: tianshilei1992

Differential Revision: https://reviews.llvm.org/D132891

Added: 
    

Modified: 
    openmp/libomptarget/test/unified_shared_memory/api.c

Removed: 
    


################################################################################
diff  --git a/openmp/libomptarget/test/unified_shared_memory/api.c b/openmp/libomptarget/test/unified_shared_memory/api.c
index 1dc4622bbc8b..3b30843f0b44 100644
--- a/openmp/libomptarget/test/unified_shared_memory/api.c
+++ b/openmp/libomptarget/test/unified_shared_memory/api.c
@@ -3,8 +3,8 @@
 // XFAIL: nvptx64-nvidia-cuda-LTO
 
 // Fails on amdgpu with error: GPU Memory Error
-// XFAIL: amdgcn-amd-amdhsa
-// XFAIL: amdgcn-amd-amdhsa-LTO
+// UNSUPPORTED: amdgcn-amd-amdhsa
+// UNSUPPORTED: amdgcn-amd-amdhsa-LTO
 
 #include <stdio.h>
 #include <omp.h>


        


More information about the Openmp-commits mailing list