[Openmp-commits] [PATCH] D123242: [OpenMP] Change target memory tests to use allocators

[Joseph Huber via Phabricator via Openmp-commits]

jhuber6 added inline comments.


================
Comment at: openmp/libomptarget/test/api/omp_device_managed_memory.c:11
+  int *shared_ptr =
+      omp_alloc(N * sizeof(int), llvm_omp_target_shared_mem_alloc);
 
----------------
jdoerfert wrote:
> This sounds so confusing to me. Shared mem alloc, is not using shared/local memory but managed memory, right?
> Just to make sure. Maybe leave a comment.
That's how they were described in the original patch, it's supposed to be "shared" between the host and device I guess.


================
Comment at: openmp/libomptarget/test/api/omp_host_pinned_memory.c:33
-    printf ("PASS\n");
+    printf("PASS\n");
 }
----------------
jdoerfert wrote:
> Keep the old tests around please. No need to drop support for the function just yet.
But the allocators use the function internally, this tests both that function and the allocator


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123242/new/

https://reviews.llvm.org/D123242