[Openmp-commits] [PATCH] D123242: [OpenMP] Change target memory tests to use allocators

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added inline comments.


================
Comment at: openmp/libomptarget/test/api/omp_device_managed_memory.c:11
+  int *shared_ptr =
+      omp_alloc(N * sizeof(int), llvm_omp_target_shared_mem_alloc);
 
----------------
This sounds so confusing to me. Shared mem alloc, is not using shared/local memory but managed memory, right?
Just to make sure. Maybe leave a comment.


================
Comment at: openmp/libomptarget/test/api/omp_host_pinned_memory.c:33
-    printf ("PASS\n");
+    printf("PASS\n");
 }
----------------
Keep the old tests around please. No need to drop support for the function just yet.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123242/new/

https://reviews.llvm.org/D123242