[Openmp-commits] [PATCH] D122645: [OpenMP][NFC] lit: Allow setting default environment variables for test

[Joachim Protze via Phabricator via Openmp-commits]

protze.joachim added a comment.

I checked the runtime tests and found that openmp/runtime/test/barrier/omp_barrier.c already triggers different combinations of barriers. Do the combinations cover all configurations you tried manually?
Regarding reductions, I think it would make sense to add similar run lines to openmp/runtime/test/worksharing/for/omp_for_reduction.c in order to cover different code paths in the runtime.

Probably @AndreyChurbanov has suggestions regarding tests that could be augmented to improve test coverage of the different barrier implementations.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122645/new/

https://reviews.llvm.org/D122645