[Openmp-commits] [PATCH] D122645: [OpenMP][NFC] lit: Allow setting default environment variables for test

[Misono Tomohiro via Phabricator via Openmp-commits]

t-msn added a comment.

> I think, in addition to manually selecting the barrier implementation, we should add additional run lines to specific tests that trigger the different barrier implementations. I added a related, OMPT-specific comment to D123193 <https://reviews.llvm.org/D123193>.

I agree. The problem is I'm not so sure which tests are needed to run when changing barrier especially for dist which affects thread handling code in kmp_runtime.cpp. 
At least, for OMPT part, I believe reduction is only affected tests for different barrier implementation. So, I will update or add patch as suggested.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122645/new/

https://reviews.llvm.org/D122645