[Openmp-commits] [PATCH] D112490: [OpenMP][Offloading] Calculate offset in libomptarget

Mon Oct 25 14:45:10 PDT 2021

grokos added a comment.

In D112490#3085835 <https://reviews.llvm.org/D112490#3085835>, @tianshilei1992 wrote:

> I see. Thanks for the information. We don't support the case you mentioned in current repo, right? I did check all uses of the offsets in current repo, but looks like they just add them up everywhere.

That's right, every plugin we currently have in the open-source repo operates on bases, that's why it's not clear why we separated args and offsets a few years ago. Maybe we should add a comment in the code pointing to D33028 <https://reviews.llvm.org/D33028> to keep things clear.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112490/new/

https://reviews.llvm.org/D112490