[Openmp-commits] [PATCH] D112490: [OpenMP][Offloading] Calculate offset in libomptarget
Shilei Tian via Phabricator via Openmp-commits
openmp-commits at lists.llvm.org
Mon Oct 25 14:42:07 PDT 2021
tianshilei1992 abandoned this revision.
tianshilei1992 added a comment.
In D112490#3085810 <https://reviews.llvm.org/D112490#3085810>, @grokos wrote:
> We need to keep bases and offsets separate. Sometimes (e.g. in OpenCL) we need to manifest base pointers prior to launching a kernel. Even if you have mapped an object only partially, e.g. `A[N:M]`, although the kernel is expected to access elements starting at address `&A[N]` and beyond, we still need to manifest the base of the array `&A`. That's why we pass args and offsets as two separate entities. What you are trying to do with this patch is to revert https://reviews.llvm.org/D33028.
I see. Thanks for the information. We don't support the case you mentioned in current repo, right? I did check all uses of the offsets in current repo, but looks like they just add them up everywhere.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the Openmp-commits