[Openmp-commits] [PATCH] D111983: [libomptarget][DeviceRTL] Generalise and simplify cmakelists

Fri Oct 22 11:40:08 PDT 2021

tianshilei1992 added inline comments.

================
Comment at: openmp/libomptarget/DeviceRTL/CMakeLists.txt:195
+  # By default, add_custom_command only builds the tool if the executable is missing
+  if("${LINK_TOOL}" STREQUAL "$<TARGET_FILE:llvm-link>")
+    add_custom_command(OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/${bclib_name}
----------------
Meinersbur wrote:
> JonChesterfield wrote:
> > Is this stuff not here to work around opt / llvm-link sometimes not being targets?
> Mostly to only add a dependency only when configured to use in-tree llvm-link/opt. `llvm-link` os a target in both, the LLVM_ENABLE_PROJECTS and LLVM_ENABLE_RUNTIMES (an "import target" from `find_package(LLVM)`) build. 
That's why I said this [[ https://reviews.llvm.org/D111983#3071576 | here ]].

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111983/new/

https://reviews.llvm.org/D111983