[Openmp-commits] [PATCH] D110699: [OpenMP][OMPT] thread_num determination during execution of nested serialized parallel regions

[Joachim Protze via Phabricator via Openmp-commits]

protze.joachim added a comment.

Overall looks good to me besides one inline comment.
I successfully tested with gcc/11, icc/19 and latest clang.



================
Comment at: openmp/runtime/test/ompt/parallel/nested_lwt_thread_num.c:87
+  // thread_num is the most important
+  // CHECK: {{^}}[[WORKER_ID]]: ancestor_level=0 id=1
+  // CHECK-SAME: parallel_id=[[PARALLEL_ID_1]] task_id=[[TASK_ID_2]]
----------------
There is no guaranteed ordering of implicit task begin on primary thread and the output on the worker thread. 
Adding a barrier at the beginning of the parallel region should make the test more robust.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110699/new/

https://reviews.llvm.org/D110699