[Openmp-commits] [PATCH] D111983: [libomptarget][DeviceRTL] Generalise and simplify cmakelists

[Michael Kruse via Phabricator via Openmp-commits]

Meinersbur requested changes to this revision.
Meinersbur added a comment.
This revision now requires changes to proceed.

In D111983#3071248 <https://reviews.llvm.org/D111983#3071248>, @JonChesterfield wrote:

> Simplifying the current script before semantics change seems a good move.

This was what I am suggestion. If the current patch is working, I am ok with keeping it as-is.

However, regarding the correctness of the this patch it is required to have any

  add_custom_command(<target> ... APPEND)

occur after

  add_custom_command(<target> ...  COMMAND)

as by CMake's documentation:

> APPEND
> Append the COMMAND and DEPENDS option values to the custom command for the first output specified. There must have already been a previous call to this command with the same output.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111983/new/

https://reviews.llvm.org/D111983