[Openmp-commits] [PATCH] D111983: [libomptarget][DeviceRTL] Generalise and simplify cmakelists

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added a comment.

IMO the dependence should be, if we are using out of tree build, check the three binaries ahead of time and return error directly if anything is wrong. We don't need to set dependence from custom target to the three binaries in this mode. For in tree build, we use the target file to for the custom command, and use the target name for dependences.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111983/new/

https://reviews.llvm.org/D111983