[Openmp-commits] [PATCH] D110435: [OpenMP][host runtime] Add initial hybrid CPU support

[Jonathan Peyton via Phabricator via Openmp-commits]

jlpeyton updated this revision to Diff 378227.
jlpeyton added a comment.

Addressed patch comments

Moved small fixup of RTM CPUID bit check into small commit that prefixes this one:

  diff --git a/openmp/runtime/src/kmp_utility.cpp b/openmp/runtime/src/kmp_utility.cpp
  index bf3e6114e0c2..8118548c162c 100644
  --- a/openmp/runtime/src/kmp_utility.cpp
  +++ b/openmp/runtime/src/kmp_utility.cpp
  @@ -247,15 +247,15 @@ void __kmp_query_cpuid(kmp_cpuinfo_t *p) {
                   i, buf.eax, buf.ebx, buf.ecx, buf.edx));
       }
   #endif
  -#if KMP_USE_ADAPTIVE_LOCKS
       p->flags.rtm = 0;
       if (max_arg > 7) {
         /* RTM bit CPUID.07:EBX, bit 11 */
         __kmp_x86_cpuid(7, 0, &buf);
         p->flags.rtm = (buf.ebx >> 11) & 1;
  -      KA_TRACE(trace_level, (" RTM"));
  +      if (p->flags.rtm) {
  +        KA_TRACE(trace_level, (" RTM"));
  +      }
       }
  -#endif
     }
  
     { // Parse CPU brand string for frequency, saving the string for later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110435/new/

https://reviews.llvm.org/D110435

Files:
  openmp/runtime/src/i18n/en_US.txt
  openmp/runtime/src/kmp.h
  openmp/runtime/src/kmp_affinity.cpp
  openmp/runtime/src/kmp_affinity.h
  openmp/runtime/src/kmp_utility.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110435.378227.patch
Type: text/x-patch
Size: 8912 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20211008/512cf5f0/attachment-0001.bin>