[Openmp-commits] [PATCH] D110435: [OpenMP][host runtime] Add initial hybrid CPU support

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added inline comments.


================
Comment at: openmp/runtime/src/kmp_affinity.h:601-607
+// Change this number with the below enum after adding new core tyeps
+#if KMP_ARCH_X86 || KMP_ARCH_X86_64
+#define KMP_HW_MAX_NUM_CORE_TYPES 3
+#else
+// Arch only has one core type per CPU socket
+#define KMP_HW_MAX_NUM_CORE_TYPES 1
+#endif
----------------
Move this into the enum directly (as an enum value). Much easier to realize they belong together.


================
Comment at: openmp/runtime/src/kmp_affinity.h:609-611
+  KMP_HW_CORE_TYPE_UNKNOWN = 0x0
+#if KMP_ARCH_X86 || KMP_ARCH_X86_64
+  ,
----------------



================
Comment at: openmp/runtime/src/kmp_affinity.h:613
+  KMP_HW_CORE_TYPE_ATOM = 0x20,
+  KMP_HW_CORE_TYPE_CORE = 0x40
+#endif
----------------



================
Comment at: openmp/runtime/src/kmp_utility.cpp:250
 #endif
-#if KMP_USE_ADAPTIVE_LOCKS
     p->flags.rtm = 0;
----------------
This looks unrelated to "hybrid CPU" changes, no?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110435/new/

https://reviews.llvm.org/D110435