[Openmp-commits] [PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield requested changes to this revision.
JonChesterfield added a reviewer: ronl.
JonChesterfield added a comment.
This revision now requires changes to proceed.

Marking as request changes because:
`if (DEFINED ENV{ROCM_PATH})`
Looking at environment variables is strictly worse than looking at cmake variables. I think we should replace /opt/rocm with a cmake variable that points to somewhere to find rocr/roct, and have no strong feelings about what the cmake variable should be called


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109885/new/

https://reviews.llvm.org/D109885