[Openmp-commits] [PATCH] D114270: [openmp][amdgpu][nfc] Simplify implicit args handling

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added inline comments.


================
Comment at: openmp/libomptarget/plugins/amdgpu/impl/system.cpp:488
+    // TODO: Probably don't want this arithmetic 
     info.kernel_segment_size =
+        (hasHiddenArgs ? kernel_explicit_args_size : kernel_segment_size);
----------------
info.kernel_segment_size is only written here


================
Comment at: openmp/libomptarget/plugins/amdgpu/src/rtl.cpp:1634
         atl_kernel_info_t info = It->second;
-        // return the size for non-implicit args
-        kernarg_segment_size =
-            info.kernel_segment_size - sizeof(impl_implicit_args_t);
+        kernarg_segment_size = info.kernel_segment_size;
       } else {
----------------
info.kernel_segment_size is only read here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114270/new/

https://reviews.llvm.org/D114270