[Openmp-commits] [PATCH] D114083: [OpenMP] Disable libomptarget profiling by default if built via the "runtimes" setup
Joachim Protze via Phabricator via Openmp-commits
openmp-commits at lists.llvm.org
Wed Nov 17 11:19:39 PST 2021
protze.joachim added inline comments.
Comment at: openmp/CMakeLists.txt:60
# there is no point in trying to compile libomptarget on other OSes.
if (APPLE OR WIN32 OR NOT OPENMP_HAVE_STD_CPP14_FLAG)
For the cross-compilation use case, shouldn't the question be whether the code is compiled for Windows/MacOS rather than compiled on Windows/MacOS?
Comment at: openmp/CMakeLists.txt:65
+if (ENABLE_LIBOMPTARGET AND NOT LLVM_RUNTIMES_BUILD)
+ set(ENABLE_LIBOMPTARGET_PROFILING ON)
Can we check, whether the target architectures for llvm and runtimes are the same? In that case, building with profiling sounds reasonable.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the Openmp-commits