[Openmp-commits] [PATCH] D113963: [OpenMP] Fix initializer not working on AMDGPU
Jon Chesterfield via Phabricator via Openmp-commits
openmp-commits at lists.llvm.org
Tue Nov 16 00:14:58 PST 2021
JonChesterfield added a reviewer: JonChesterfield.
JonChesterfield accepted this revision.
JonChesterfield added a comment.
There's a recent llvm pass that gathers ctor/dtor into one or more kernels that expect to be executed with one wavefront, possibly one thread active at the entry point. I'm aware of two bugs in it, one fixed and one with a patch outstanding. These aren't actually run by the amdgpu plugin yet but probably will be shortly. At least the constructors, I'm not clear how we would know when to run the destructors. At that point we could optionally revert this, looks good for now.
Moving one-off initialisation to a global ctor, once said ctor is actually executed by the plugin, is probably a minor performance win. Do some work once instead of once per kernel.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the Openmp-commits